fix: Set operation state to nil if new operation has been initiated by a direct object update (#20875) #20915
+115
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
andrii-korotkov-verkada
force-pushed
the
20875-update-status-if-operation-state-was-added
branch
2 times, most recently
from
a1774d2
to
f815b02
Compare
|
According to @stephaneetje testing, this indeed fixes the issues with old sync information being shown and app out of sync. |
andrii-korotkov-verkada
force-pushed
the
20875-update-status-if-operation-state-was-added
branch
19 times, most recently
from
17f0e30
to
cfaa19e
Compare
…y a direct object update (argoproj#20875) Fixes argoproj#20875 Some systems like Kargo update the application operation directly to initiate a new sync, bypassing the server. However, they can't update the status operation state to become nil, resulting in discrepancy, see akuity/kargo#2985 and the discussion. Handle this case on the app controller side. Let's cherry-pick to v2.13. Signed-off-by: Andrii Korotkov <[email protected]>
andrii-korotkov-verkada
force-pushed
the
20875-update-status-if-operation-state-was-added
branch
from
cfaa19e
to
bb5db09
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20915 +/- ##
==========================================
- Coverage 55.04% 54.98% -0.06%
==========================================
Files 324 324
Lines 55421 55480 +59
==========================================
+ Hits 30504 30505 +1
- Misses 22303 22347 +44
- Partials 2614 2628 +14 ☔ View full report in Codecov by Sentry. |
andrii-korotkov-verkada
requested review from
crenshaw-dev and
ishitasequeira
|
Is there any chance to get this PR merged for the next release ? |
|
Please prioritize releasing this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20875
Some systems like Kargo update the application operation directly to initiate a new sync, bypassing the server. However, they can't update the status operation state to become nil, resulting in discrepancy, see akuity/kargo#2985 and the discussion. Handle this case on the app controller side.
Let's cherry-pick to v2.13.
Checklist: